-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make cni plugin configurable in scaling test scenario #15557
Conversation
Hi @prateekgogia. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
1 similar comment
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
will cut a follow up PR in test-infra to make use of these variables. |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
1 similar comment
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
@@ -96,7 +98,8 @@ create_args+=("--node-count=${KUBE_NODE_COUNT:-101}") | |||
# However, it currently fails two tests (HostPort & OIDC) so need to track that down | |||
#create_args="--dns none" | |||
create_args+=("--node-size=c6g.medium") | |||
create_args+=("--master-size=c6g.2xlarge") | |||
create_args+=("--control-plane-count=2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be either 1 or 3. Also, not sure what the reason is to increase the control-plane number. It will probably decrease performance.
create_args+=("--control-plane-count=2") | |
create_args+=("--control-plane-count=3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I was just trying to figure this out, should kops have this validation to fail the cluster creation if the size is 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the reason we want to add more CP nodes is to be able to perform a 5k kube nodes scale test. I have made this count configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 CP nodes should also be doable, never tried it though. Let's do that separately.
Each CP has etcd running. The more etcd replicas, the slower it gets. (my reasoning)
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
2 similar comments
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
/lgtm |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
@prateekgogia: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
* make cni plugin configurable * include image and instance type variables * fix variable name * rename CP size variable name and add CP count=2 * fix CP count * Update flag name to master size and count * Use 20.04 ubuntu version
No description provided.