Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make cni plugin configurable in scaling test scenario #15557

Merged
merged 7 commits into from
Jun 29, 2023
Merged

make cni plugin configurable in scaling test scenario #15557

merged 7 commits into from
Jun 29, 2023

Conversation

prateekgogia
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @prateekgogia. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman hakman changed the title make cni plugin configurable make cni plugin configurable in scaling test scenario Jun 28, 2023
@hakman
Copy link
Member

hakman commented Jun 28, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 28, 2023
@hakman
Copy link
Member

hakman commented Jun 28, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Jun 28, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

1 similar comment
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@prateekgogia
Copy link
Contributor Author

will cut a follow up PR in test-infra to make use of these variables.

@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

1 similar comment
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

hakman
hakman reviewed Jun 29, 2023
View reviewed changes
tests/e2e/scenarios/scalability/run-test.sh Outdated
@@ -96,7 +98,8 @@ create_args+=("--node-count=${KUBE_NODE_COUNT:-101}")
# However, it currently fails two tests (HostPort & OIDC) so need to track that down
#create_args="--dns none"
create_args+=("--node-size=c6g.medium")
create_args+=("--master-size=c6g.2xlarge")
create_args+=("--control-plane-count=2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be either 1 or 3. Also, not sure what the reason is to increase the control-plane number. It will probably decrease performance.

Suggested change
create_args+=("--control-plane-count=2")
create_args+=("--control-plane-count=3")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I was just trying to figure this out, should kops have this validation to fail the cluster creation if the size is 2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the reason we want to add more CP nodes is to be able to perform a 5k kube nodes scale test. I have made this count configurable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 CP nodes should also be doable, never tried it though. Let's do that separately.
Each CP has etcd running. The more etcd replicas, the slower it gets. (my reasoning)

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2023
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@hakman hakman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 29, 2023
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@prateekgogia prateekgogia mentioned this pull request Jun 29, 2023
Merged
@hakman
Copy link
Member

hakman commented Jun 29, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

2 similar comments
@hakman
Copy link
Member

hakman commented Jun 29, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Jun 29, 2023

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@hakman
Copy link
Member

hakman commented Jun 29, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot k8s-ci-robot merged commit 403dc27 into kubernetes:master Jun 29, 2023
@prateekgogia prateekgogia deleted the cni_config branch June 30, 2023 21:05
@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

@k8s-ci-robot
Copy link
Contributor

@prateekgogia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-kops-aws-scale-amazonvpc-using-cl2 d591af0 link unknown /test presubmit-kops-aws-scale-amazonvpc-using-cl2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@prateekgogia
Copy link
Contributor Author

/test presubmit-kops-aws-scale-amazonvpc-using-cl2

tesspib pushed a commit to tesspib/kops that referenced this pull request Jul 18, 2023
@prateekgogia @tesspib
make cni plugin configurable in scaling test scenario (kubernetes#15557)
10a8cad 
* make cni plugin configurable

* include image and instance type variables

* fix variable name

* rename CP size variable name and add CP count=2

* fix CP count

* Update flag name to master size and count

* Use 20.04 ubuntu version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prateekgogia @k8s-ci-robot @hakman @k8s-triage-robot