-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add removeAll to vfs #15395
add removeAll to vfs #15395
Conversation
|
Welcome @Codelax! |
Hi @Codelax. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Codelax Could you try using |
@hakman Yes I have thought of that but it seems like a drastic change to go from soft delete to hard delete. |
/ok-to-test |
Thanks @Codelax - this looks like a great change. One tip for the future, I think if you're not personally using OpenStack/Swift I would have just left it as the no-change implementation. Then we can let whoever uses OpenStack/Swift implement and verify it in their scenario. That said, I think the changes look good, so I'm going to approve! Thanks for the contribution :-) /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds
RemoveAll
to vfs interface.The goal of this method is to avoid deleting files one by one if the implementation allows it.
When deleting a cluster that ran for a while, it can take a very long time to delete all backups.
I personally use s3 as state-store, I tried to implement it for other providers when I could find useful methods in their APIs. For other providers I resolved to use a loop, it does not change from the current implementation and it could be improved later on.
For the swift implementation, I used the default 10k bulk items but I'm not sure about this one as this seems to be configurable per swift instance.
I also found partially the same code with
RemoveAllVersion
although this only target object versions/snapshots. But this one does not seems to be used elsewhere in the code.