add removeAll to vfs

[Codelax]

Adds RemoveAll to vfs interface.
The goal of this method is to avoid deleting files one by one if the implementation allows it.
When deleting a cluster that ran for a while, it can take a very long time to delete all backups.

I personally use s3 as state-store, I tried to implement it for other providers when I could find useful methods in their APIs. For other providers I resolved to use a loop, it does not change from the current implementation and it could be improved later on.

For the swift implementation, I used the default 10k bulk items but I'm not sure about this one as this seems to be configurable per swift instance.

I also found partially the same code with RemoveAllVersion although this only target object versions/snapshots. But this one does not seems to be used elsewhere in the code.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Codelax / name: Jules Castéran (e27ae94)

[k8s-ci-robot]

Welcome @Codelax!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Codelax. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

@Codelax Could you try using RemoveAllVersions()? It is used by etcd-manager and should work for non-versioned things also.

[Codelax]

@hakman Yes I have thought of that but it seems like a drastic change to go from soft delete to hard delete.
If one use a versioned bucket to store state and backups it would be a breaking change.

[hakman]

/ok-to-test

[hakman]

/cc @justinsb @zetaab

[justinsb]

Thanks @Codelax - this looks like a great change.

One tip for the future, I think if you're not personally using OpenStack/Swift I would have just left it as the no-change implementation. Then we can let whoever uses OpenStack/Swift implement and verify it in their scenario.

That said, I think the changes look good, so I'm going to approve!

Thanks for the contribution :-)

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment