-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nvidia container toolkit repos #15096
Fix nvidia container toolkit repos #15096
Conversation
Welcome @elezar! |
Hi @elezar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The ubuntu20.04 and ubunut22.04 repositories are "mirrors" of the ubuntu18.04 repository. This change ensures that the ubuntu18.04 repository is used regardless of the Ubuntu distribution. Signed-off-by: Evan Lezar <[email protected]>
The same gpgkey is served from both the nvidia-container-runtime and libnvidia-container repos. Signed-off-by: Evan Lezar <[email protected]>
As of the NVIDIA Container Toolkit v1.6.0 release the nvidia-container-toolkit is the top-level package for installing the NVIDIA container stack with the nvidia-container-runtime provided as a meta-package to support "legacy" workflows such as this. This change installs the nvidia-container-toolkit package directly instead. Note that the nvidia-container-runtime binary is included in this package. See https://github.com/NVIDIA/nvidia-container-toolkit/releases/tag/v1.6.0 Signed-off-by: Evan Lezar <[email protected]>
93d559f
to
02adbc7
Compare
Thanks @elezar. Much appreciated! |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to fix this.
@elezar do you want to do cherry pick of this PR to release-1.26 + release-1.25 as well? Its broken there as well |
@zetaab Probably easier if you do it. I can approve those PRs. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.26 Automated cherry pick of #15096: Use ubuntu18.04 repos for nvidia-container-toolkit
…-upstream-release-1.25 Automated cherry pick of #15096: Use ubuntu18.04 repos for nvidia-container-toolkit
Thanks for the quick turnaround on this! |
…-of-#15096-upstream-release-1.26 Automated cherry pick of kubernetes#15096: Use ubuntu18.04 repos for nvidia-container-toolkit
This PR updates the repositories and the installation of the NVIDIA Container Toolkit.
This ensures that #15094 is less likely to occur in future.