Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics-server: Set preferred address type to InternalIP when non AWS #14709

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 2, 2022

Closes #14708

/cc @olemarkus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/addons labels Dec 2, 2022
@hakman hakman force-pushed the metrcis-server_internal-ip branch from d36642c to ef2e002 Compare December 2, 2022 13:11
@hakman hakman added the area/provider/gcp Issues or PRs related to gcp provider label Dec 2, 2022
@hakman hakman force-pushed the metrcis-server_internal-ip branch from ef2e002 to 2b176ae Compare December 3, 2022 20:38
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2d81043 into kubernetes:master Dec 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics-server failing to scrape nodes due to timeout and DNS lookup errors
3 participants