Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s.io/client-go to match k8s.io/api #14003

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 19, 2022

... and remove replaces from go.mod files.
Mostly a back-port of #13789 and #13841.

Fixes: #14000

/cc @rifelpet @olemarkus

@k8s-ci-robot k8s-ci-robot requested a review from olemarkus July 19, 2022 04:11
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jul 19, 2022
@k8s-ci-robot k8s-ci-robot requested a review from rifelpet July 19, 2022 04:11
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2022
k8s.io/mount-utils => k8s.io/mount-utils v0.24.0
k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.24.0
)
replace k8s.io/client-go => k8s.io/client-go v0.24.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this to be v0.24.2 as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters much.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit b802e58 into kubernetes:release-1.24 Jul 21, 2022
@hakman hakman deleted the remove_replaces_1.24 branch July 29, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants