Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected type for object metadata when using gossip DNS #13592

Merged
merged 1 commit into from
May 3, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented May 3, 2022

Before:

yaml.go:53] MetadataObj: map[creationTimestamp:<nil> labels:map[discovery.kops.k8s.io/internal-name:api.internal.test1.k8s.local] name:api-internal namespace:kube-system]:
yaml.go:58] unexpected type for object metadata: map[string]interface {}
yaml.go:63] MetadataObj: map[creationTimestamp:<nil> labels:map[discovery.kops.k8s.io/internal-name:api.internal.test1.k8s.local] name:api-internal namespace:kube-system]:
yaml.go:53] MetadataObj: map[creationTimestamp:<nil> labels:map[discovery.kops.k8s.io/internal-name:kops-controller.internal.test1.k8s.local] name:kops-controller-internal namespace:kube-system]:
yaml.go:58] unexpected type for object metadata: map[string]interface {}
yaml.go:63] MetadataObj: map[creationTimestamp:<nil> labels:map[discovery.kops.k8s.io/internal-name:kops-controller.internal.test1.k8s.local] name:kops-controller-internal namespace:kube-system]:

After:

yaml.go:53] MetadataObj: map[creationTimestamp:<nil> labels:map[discovery.kops.k8s.io/internal-name:api.internal.test1.k8s.local] name:api-internal namespace:kube-system]:
yaml.go:63] MetadataObj: map[labels:map[discovery.kops.k8s.io/internal-name:api.internal.test1.k8s.local] name:api-internal namespace:kube-system]:
yaml.go:53] MetadataObj: map[creationTimestamp:<nil> labels:map[discovery.kops.k8s.io/internal-name:kops-controller.internal.test1.k8s.local] name:kops-controller-internal namespace:kube-system]:
yaml.go:63] MetadataObj: map[labels:map[discovery.kops.k8s.io/internal-name:kops-controller.internal.test1.k8s.local] name:kops-controller-internal namespace:kube-system]:

@hakman hakman added the area/provider/hetzner Issues or PRs related to Hetzner provider label May 3, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from olemarkus and rdrgmnzs May 3, 2022 06:44
@hakman hakman added the kind/bug Categorizes issue or PR as related to a bug. label May 3, 2022
@hakman
Copy link
Member Author

hakman commented May 3, 2022

/test all

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit ec7545f into kubernetes:master May 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone May 3, 2022
k8s-ci-robot added a commit that referenced this pull request May 3, 2022
…-upstream-release-1.23

Automated cherry pick of #13592: Fix unexpected type for object metadata when using gossip DNS
@hakman hakman deleted the fix_metadata_obj_type branch May 3, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/hetzner Issues or PRs related to Hetzner provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants