Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump NTH 1.16 and add excludeFromLoadBalancers option #13467

Merged
merged 5 commits into from
Apr 9, 2022
Merged

Bump NTH 1.16 and add excludeFromLoadBalancers option #13467

merged 5 commits into from
Apr 9, 2022

Conversation

DingGGu
Copy link
Contributor

@DingGGu DingGGu commented Apr 7, 2022

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 7, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: DingGGu / name: DingGGu (79db448)

@k8s-ci-robot
Copy link
Contributor

Welcome @DingGGu!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @DingGGu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman
Copy link
Member

hakman commented Apr 7, 2022

/ok-to-test

@hakman
Copy link
Member

hakman commented Apr 7, 2022

/cc @olemarkus

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2022
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus April 7, 2022 14:43
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2022
@hakman hakman removed the request for review from joshbranham April 7, 2022 14:53
olemarkus
olemarkus requested changes Apr 7, 2022
View reviewed changes
upup/models/cloudup/resources/addons/node-termination-handler.aws/k8s-1.11.yaml.template Outdated
@@ -183,6 +197,8 @@ spec:
value: "false"
- name: ENABLE_SQS_TERMINATION_DRAINING
value: "true"
- name: EXCLUDE_FROM_LOAD_BALANCERS
value: "{{ .ExcludeFromLoadBalancers }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use WithDefaultBool here since ExcludeFromLoadBalancers is a pointer and go templates will evaluate pointers as non-nil or not, also for boolean pointers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will try to use WithDefaultBool for all nth manifest.

pkg/model/components/nodeterminationhandler.go Outdated
@@ -51,6 +51,9 @@ func (b *NodeTerminationHandlerOptionsBuilder) BuildOptions(o interface{}) error
if nth.EnableRebalanceDraining == nil {
nth.EnableRebalanceDraining = fi.Bool(false)
}
if nth.ExcludeFromLoadBalancers == nil {
nth.ExcludeFromLoadBalancers = fi.Bool(false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any downsides to enabling this by default?

Copy link
Contributor Author

@DingGGu DingGGu Apr 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NTH defaults to false, but in kOps, we can set the default value to true because there is nothing bad effect with it.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2022
@DingGGu
Copy link
Contributor Author

DingGGu commented Apr 8, 2022

/retest

@hakman
Copy link
Member

hakman commented Apr 8, 2022

@DingGGu You may have to run make apimachinery and hack/update-expected.sh and commit the changes to get the tests passing.

@DingGGu DingGGu force-pushed the master branch 2 times, most recently from 735a68f to 6c0d579 Compare April 8, 2022 09:01
@DingGGu
Copy link
Contributor Author

DingGGu commented Apr 8, 2022

maybe need /ok-to-test for this PR

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit a62d8cc into kubernetes:master Apr 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@hakman hakman Awaiting requested review from hakman

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@DingGGu @k8s-ci-robot @hakman @olemarkus