Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use k8s.gcr.io for k8s side-loaded images #13402

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Use k8s.gcr.io for k8s side-loaded images #13402

merged 1 commit into from
Mar 23, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Mar 23, 2022

Refs: #13365

@hakman hakman requested a review from olemarkus March 23, 2022 09:00
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2022
@hakman
Copy link
Member Author

hakman commented Mar 23, 2022

/retest

@hakman hakman force-pushed the fix_k8s_side-loading branch 2 times, most recently from 46143f3 to 72def22 Compare March 23, 2022 09:39
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2022
@hakman hakman force-pushed the fix_k8s_side-loading branch from 72def22 to 759172c Compare March 23, 2022 10:22
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2022
@hakman
Copy link
Member Author

hakman commented Mar 23, 2022

/retest

@hakman
Copy link
Member Author

hakman commented Mar 23, 2022

/test all

@k8s-ci-robot k8s-ci-robot merged commit acacf62 into kubernetes:master Mar 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 23, 2022
@hakman hakman deleted the fix_k8s_side-loading branch March 23, 2022 11:38
@ameukam
Copy link
Member

ameukam commented Mar 23, 2022 •
edited
Loading

@hakman curious about why the switch to k8s.gcr.io. Anything we need to improve for registry.k8s.io ? 🙇🏾

@hakman
Copy link
Member Author

hakman commented Mar 23, 2022

@ameukam We sideload k8s images from .tgz files. Those are built with k8s.gcr.io as registry. Once registry.k8s.io is GA, k/k should switch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-ci-robot @ameukam @olemarkus