Clean up kops build targets #13390
Merged
Clean up kops build targets #13390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hakman
reviewed
Mar 21, 2022
Makefile
Outdated
| @@ -184,34 +177,40 @@ test: | |||
| test-windows: | |||
| go test -v $(go list ./... | grep -v /nodeup/) | |||
|
|
|||
|
|
|||
| .PHONY: kops | |||
| kops: crossbuild-$(shell go env GOOS)-$(shell go env GOARCH) | |||
There was a problem hiding this comment.
Maybe we should be more explicit and use crossbuild-kops-..., or just drop crossbuild- completely?
There was a problem hiding this comment.
I thought about it, but didn't want to change the naming of targets in this PR. But it is something we should look at.
There was a problem hiding this comment.
I think the only one that already exists is crossbuild, all the rest are new.
olemarkus
force-pushed
the
crossbuild-kops
branch
from
cdab347 to
5e25bdb
Compare
hakman
approved these changes
Mar 21, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Reuse kops builds in kops-install Do not force rebuilds Fix all target Fix docs target Add binary name to kops crossbuild targets
olemarkus
force-pushed
the
crossbuild-kops
branch
from
5e25bdb to
5b90e58
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.