Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to registry.k8s.io #13380

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Migrate to registry.k8s.io #13380

merged 2 commits into from
Mar 18, 2022

Conversation

hakman
Copy link
Member

@hakman hakman commented Mar 17, 2022

Fixes #13365

/cc @justinsb @olemarkus
/hold for feedback

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2022
@hakman hakman added kind/office-hours and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2022
@hakman hakman force-pushed the migrate_to_registry.k8s.io branch from e642ea5 to 69dcf58 Compare March 17, 2022 10:58
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 17, 2022
@hakman hakman force-pushed the migrate_to_registry.k8s.io branch 2 times, most recently from 31c71d8 to 5625152 Compare March 17, 2022 17:17
@hakman
Copy link
Member Author

hakman commented Mar 17, 2022

/test pull-kops-e2e-kubernetes-aws

@hakman
Copy link
Member Author

hakman commented Mar 17, 2022

Looks ready now. @justinsb could you take a look?
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
@ameukam
Copy link
Member

ameukam commented Mar 17, 2022

@hakman is the revert easy in case we see some unexpected behaviors on the new endpoint ?

@hakman
Copy link
Member Author

hakman commented Mar 17, 2022

@ameukam Revert should be pretty easy.

@hakman
Copy link
Member Author

hakman commented Mar 17, 2022

@ameukam Do we have a plan to make the new endpoint GA?

@ameukam
Copy link
Member

ameukam commented Mar 17, 2022

@ameukam Do we have a plan to make the new endpoint GA?

We are currently working on make it GA in the incoming weeks. In his current shape, it's usable for the community. We are more focused on scalability.

@hakman
Migrate to registry.k8s.io
a4ed2b0 
Signed-off-by: Ciprian Hacman <[email protected]>
@hakman hakman force-pushed the migrate_to_registry.k8s.io branch from 5625152 to e5662ef Compare March 18, 2022 06:47
@hakman
Run hack/update-expected.sh
30404d6 
Signed-off-by: Ciprian Hacman <[email protected]>
@hakman hakman force-pushed the migrate_to_registry.k8s.io branch from e5662ef to 30404d6 Compare March 18, 2022 07:02
@hakman
Copy link
Member Author

hakman commented Mar 18, 2022

@ameukam Do we have a plan to make the new endpoint GA?

We are currently working on make it GA in the incoming weeks. In his current shape, it's usable for the community. We are more focused on scalability.

Sounds good @ameukam. As long as it's GA in the next few months I don't see any issues.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit e567be2 into kubernetes:master Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 18, 2022
@hakman hakman mentioned this pull request Mar 18, 2022
Merged
@hakman hakman deleted the migrate_to_registry.k8s.io branch March 23, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
registry.k8s.io (SIG K8S Infra)
Status: Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

migrate to registry.k8s.io
4 participants
@hakman @ameukam @k8s-ci-robot @olemarkus