Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return a '-1' exit if no keys found and json/yaml output #13378

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

hierynomus
Copy link
Contributor

In our CI scripts we wanted to adapt to the new sshpublickey command, however for a new cluster this will exit non-successfully if there are no keys yet. It is possible to work around this with some ugly hacks, however for scripts I think we should return successfully if there are no public keys. It's not like something bad happened.

This PR ensures that for json/yaml output, which is for machine consumption, that even for an empty list it will exit with a 0 exit code if no errors happen.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @hierynomus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good thing to me. Thanks @hierynomus.

@hakman
Copy link
Member

hakman commented Mar 28, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@hierynomus
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3acf5b3 into kubernetes:master Mar 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 28, 2022
@hierynomus hierynomus deleted the sshkey-output branch March 28, 2022 08:02
k8s-ci-robot added a commit that referenced this pull request Mar 28, 2022
…-upstream-release-1.23

Automated cherry pick of #13378: Do not return a '-1' exit if no keys found and json/yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants