-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not return a '-1' exit if no keys found and json/yaml output #13378
Conversation
Hi @hierynomus. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good thing to me. Thanks @hierynomus.
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…-upstream-release-1.23 Automated cherry pick of #13378: Do not return a '-1' exit if no keys found and json/yaml
In our CI scripts we wanted to adapt to the new
sshpublickey
command, however for a new cluster this will exit non-successfully if there are no keys yet. It is possible to work around this with some ugly hacks, however for scripts I think we should return successfully if there are no public keys. It's not like something bad happened.This PR ensures that for json/yaml output, which is for machine consumption, that even for an empty list it will exit with a
0
exit code if no errors happen.