-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use instance ID as node name when AWS CCM supports it #12862
Use instance ID as node name when AWS CCM supports it #12862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind merging this at all, but this perhaps should be discussed in office hours first?
@@ -55,6 +55,9 @@ type ServerOptions struct { | |||
SigningCAs []string `json:"signingCAs"` | |||
// CertNames is the list of active certificate names. | |||
CertNames []string `json:"certNames"` | |||
|
|||
// UseInstanceIDForNodeName uses the instance ID instead of the hostname for the node name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently only AWS supports verified nodes, but should we still say that this is AWS specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GCE also has a verifier, but it doesn't have this issue of its CCM supporting two node naming conventions.
This is worthy of a release note since it may be surprising to users |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @olemarkus