-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for AWS ipv6 prefixes #12112
Conversation
This is the cluster settings I used.
|
37a07bf
to
fba37c1
Compare
Since there were actually interest in getting this one merged, I made the code paths configurable. The commits are still a bit messy, but feedback on the overall semantics would be appreciated. /cc @justinsb |
fba37c1
to
6aa5fec
Compare
6aa5fec
to
c5eaef8
Compare
This is the cluster config I use for this PR now.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@justinsb did you comment the nits? I only see the comment above. Since we need to enable a controller i kops-controller etc we need a flag that shows user's intent. Empty |
CCM and kops-controller taint each other out. This will make them schedule, and schedule earlier.
59ce840
to
81177dc
Compare
/lgtm |
/retest |
Ooops - I queued them up and forgot to hit send. I actually can't submit the comments now, so I guess I'll open a follow-up PR or two :-) It was mostly nits apart from the |
Using this PR you can provision a cluster using AWS prefixes.
Going forward, I expect it to be possible to enable ipv6 prefixes as part of launch templates so kOps doesn't have to do it. Meanwhile I do believe this is k8s installer territory.
I hope that in the future, the IPAM controller can be a part of CCM, but meanwhile it runs fine as part of kops-controller.