Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BLM banner #10672

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Remove BLM banner #10672

merged 1 commit into from
Apr 15, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Jan 28, 2021

Banner was already removed from the main Kubernetes site. I think it's time to do the same:
https://github.com/kubernetes/website/blob/87c6923445193d6a5d8b3d029c1f4bb4ee6562cc/data/announcements/scheduled.yaml#L55-L63

/kind office-hours

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/office-hours cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added area/documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2021
@justinsb
Copy link
Member

justinsb commented Feb 4, 2021

We discussed this in office hours; I'm going to put together a "values" page and then we can move this statement to that page.

@hakman
Copy link
Member Author

hakman commented Feb 25, 2021

justinsb added a commit to justinsb/kops that referenced this pull request Mar 21, 2021
As discussed in kubernetes#10672, we are maintaining the BLM statement on a page
dedicated to our values.

Additional values mirror the kubernetes project values.  We can
document additional values by agreement in office hours.
@justinsb justinsb mentioned this pull request Mar 21, 2021
justinsb added a commit to justinsb/kops that referenced this pull request Mar 21, 2021
As discussed in kubernetes#10672, we are maintaining the BLM statement on a page
dedicated to our values.

Additional values mirror the kubernetes project values.  We can
document additional values by agreement in office hours.
@hakman hakman closed this Apr 15, 2021
@hakman hakman deleted the remove-blm-banner branch April 15, 2021 12:05
@hakman hakman restored the remove-blm-banner branch April 15, 2021 12:25
@hakman hakman reopened this Apr 15, 2021
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@hakman hakman changed the title [WIP] Remove BLM banner Remove BLM banner Apr 15, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2021
@hakman
Copy link
Member Author

hakman commented Apr 15, 2021

With #11094 this one is unblocked now.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@hakman
Copy link
Member Author

hakman commented Apr 15, 2021

/retest

@hakman
Copy link
Member Author

hakman commented Apr 15, 2021

/test all

@hakman
Copy link
Member Author

hakman commented Apr 15, 2021

/test all

@k8s-ci-robot k8s-ci-robot merged commit 2714c66 into kubernetes:master Apr 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 15, 2021
@hakman hakman deleted the remove-blm-banner branch April 15, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants