Delay defaulting to CoreDNS to k8s v1.20 #10435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/documentation
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
rifelpet
reviewed
Dec 16, 2020
| tag = "v1.19.0-alpha.1" | ||
| default: | ||
| tag = "latest" |
There was a problem hiding this comment.
Why is this changing to latest? That might cause undesired behavior
There was a problem hiding this comment.
Changing this because there was no tag for 1.20, and we need one for the tests. I think there should be a default value here somehow.
Agreed, will add a release note soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.19 may be a bit too late in the game.
/cc @olemarkus @rifelpet