Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default runtime and runtimes fields in the docker config #10238

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

bharath-123
Copy link
Contributor

@bharath-123 bharath-123 commented Nov 14, 2020

Add the capability of defining the default runtime and runtimes fields for the docker daemon used in kops nodes.

This fixes #10127

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bharath-123. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/api labels Nov 14, 2020
@bharath-123
Copy link
Contributor Author

/cc @hakman

@k8s-ci-robot k8s-ci-robot requested a review from hakman November 14, 2020 18:52
@bharath-123
Copy link
Contributor Author

@hakman this seems alright i suppose?

@bharath-123 bharath-123 force-pushed the add-opt/docker-config branch from 9047bfc to c294e3d Compare November 14, 2020 19:53
@hakman
Copy link
Member

hakman commented Nov 14, 2020

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-123, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit a196585 into kubernetes:master Nov 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 14, 2020
k8s-ci-robot added a commit that referenced this pull request Nov 16, 2020
…-upstream-release-1.19

Automated cherry pick of #10238: dockerconfig: Add default runtime and runtimes fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include in Docker configuration a Runtime option
3 participants