Fix to handle exit code of gazelle command in hack/verify-bazel.sh

[h3poteto]

I fix a script for development.

When some diff are detected in gazelle, the command exit(1), so verify-bazel.sh exit without any messages.

For example, I run gazelle command directly:

$ _output/bin/gazelle fix -external=vendored -exclude=tests/e2e -mode=diff -proto=disable -repo_root=./
--- cmd/kops-controller/pkg/server/BUILD.bazel  1970-01-01 00:00:00.000000000 +0000
+++ cmd/kops-controller/pkg/server/BUILD.bazel  1970-01-01 00:00:00.000000000 +0000
@@ -13,9 +13,9 @@
         "//pkg/apis/nodeup:go_default_library",
         "//pkg/pki:go_default_library",
         "//pkg/rbac:go_default_library",
+        "//upup/pkg/fi:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/util/sets:go_default_library",
         "//vendor/k8s.io/klog/v2:go_default_library",
-        "//upup/pkg/fi:go_default_library",
     ],
 )
$ echo $?
1

And I run hack/verify-bazel.sh in the same condition:

$ hack/verify-bazel.sh
$ echo $? 
1

Because gazelle command exits with exit code 1 when it detects some diff, but hack/verify-bazel.sh didn't handle the exit code of gazelle command.

[k8s-ci-robot]

Hi @h3poteto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

/ok-to-test

[h3poteto]

With this fix, the command output look like this:

$ hack/verify-bazel.sh
--- cmd/kops-controller/pkg/server/BUILD.bazel  1970-01-01 00:00:00.000000000 +0000
+++ cmd/kops-controller/pkg/server/BUILD.bazel  1970-01-01 00:00:00.000000000 +0000
@@ -13,9 +13,9 @@
         "//pkg/apis/nodeup:go_default_library",
         "//pkg/pki:go_default_library",
         "//pkg/rbac:go_default_library",
+        "//upup/pkg/fi:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/util/sets:go_default_library",
         "//vendor/k8s.io/klog/v2:go_default_library",
-        "//upup/pkg/fi:go_default_library",
     ],
 )


FAIL: ./hack/verify-bazel.sh failed, as the bazel files are not up to date
FAIL: Please execute the following command: ./hack/update-bazel.sh
$ echo $?
1

[justinsb]

Thanks @h3poteto - well found!

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: h3poteto, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment