-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mount the whole /etc/ssl/certs directory for k8s-ec2-srcdst #10169
Conversation
…ployment. Signed-off-by: Marcos Soutullo Rodriguez <[email protected]>
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @kitos9112! |
Hi @kitos9112. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/etc/ssl/certs
directory for k8s-ec2-srcdst Deployment when Calico crossSubnet is On
Thanks @kitos9112. This looks nice. Once the tests pass, I will take care of merging and cherry-picking. |
upup/models/cloudup/resources/addons/networking.projectcalico.org/k8s-1.16.yaml.template
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, kitos9112 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…-upstream-release-1.19 Automated cherry pick of #10169: Mount the whole /etc/ssl/certs directory for k8s-ec2-srcdst
…-upstream-release-1.18 Automated cherry pick of #10169: Mount the whole /etc/ssl/certs directory for k8s-ec2-srcdst
This PR fixes a particular issue when deploying Calico CNI in other AMI not based on Debian where the local SSL CA Cert store doesn't always point to
ca-certificates.crt
@hakman suggested to mount the whole directory instead of referring to a file as a workaorund. More details on #10150
Signed-off-by: Marcos Soutullo Rodriguez