Fix NLB naming for terraform and cloudformation targets

[rifelpet]

This ensures we use the LoadBalancerName field rather than the name of the NLB task itself. The direct target is already using LoadBalancerName:

kops/upup/pkg/fi/cloudup/awstasks/network_load_balancer.go

Lines 503 to 504 in e91ed11

	request := &elbv2.CreateLoadBalancerInput{}
	request.Name = e.LoadBalancerName

This will need to be cherry-picked to release-1.19.

ref: #10154 (comment)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

/lgtm

[seh]

Thank you, @rifelpet. When I went to test this, I got further, but then ran into this next error from AWS:

Error: Error updating Autoscaling group: ValidationError: You must use a valid fully-formed launch template. The security group 'nlb-sg-0ef9de1ab14bee565' does not exist in VPC 'vpc-077913405bb66aac2'
	status code: 400, request id: 6e6096b8-a3a7-427a-a846-5272aa46858f

  on kubernetes.tf line 123, in resource "aws_autoscaling_group" "master-us-east-2a-masters-redacted-cluster-name":
 123: resource "aws_autoscaling_group" "master-us-east-2a-masters-redacted-cluster-name" {

In the Terraform aws_launch_template resource, the "network_interfaces.security_groups" attribute contains two entries:

• aws_security_group.masters-redacted-cluster-name.id
• "nlb-sg-0ef9de1ab14bee565"

The second security group is not defined as a Terraform resource.

That error repeats similarly for for all of the ASGs in the cluster.