Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control --create-kube-config with an environment variable or invert its default #9466

Closed
geekofalltrades opened this issue Jun 30, 2020 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@geekofalltrades
Copy link
Contributor

1. Describe IN DETAIL the feature/behavior/change you would like to see.

Our cluster uses an SSO solution in the kubeconfig for authentication to the cluster. Having Kops overwrite our kubeconfig every time we run kops update cluster is not helpful. It clobbers our working config, replacing it with a non-working config, and it installs admin-level credentials on developer desktops, which we would rather not distribute.

It's easy to forget to pass --create-kube-config=false, and so we do this fairly frequently on accident.

If we could control this behavior with an environment variable, we could all set it in .bashrc and forget about it.

Even better, if this flag's default could be inverted to false, kops update cluster would no longer have unrelated side effects on the developer's system. It could also be removed entirely, so that developers have to do it explicitly with kops export kubecfg (do one thing and do it well).

2. Feel free to provide a design supporting your feature request.

@olemarkus
Copy link
Member

100%.
This one is a duplicate of sorts to #8017 and will be fixed by #9280

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 29, 2020
@olemarkus
Copy link
Member

Already merged to master.
/close

@k8s-ci-robot
Copy link
Contributor

@olemarkus: Closing this issue.

In response to this:

Already merged to master.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants