Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should validate that names are valid DNS names #46

Closed
justinsb opened this issue Jul 5, 2016 · 0 comments
Closed

We should validate that names are valid DNS names #46

justinsb opened this issue Jul 5, 2016 · 0 comments
Labels
P0
Milestone
1.4.4

Comments

@justinsb
Copy link
Member

justinsb commented Jul 5, 2016

  • all lower-case
  • "looks like" a domain - i.e. has dots etc
  • other rules around valid DNS names
@justinsb justinsb added P1 P0 and removed P1 labels Jul 8, 2016
@justinsb justinsb modified the milestone: 1.3.0 Jul 29, 2016
justinsb added a commit to justinsb/kops that referenced this issue Aug 15, 2016
@justinsb
Validate that the cluster name is a valid DNS name
6aee952 
This should help users avoid the common mistake of just specifying the
name, not a fully-qualified domain name.

Fix kubernetes#46
@justinsb justinsb mentioned this issue Aug 15, 2016
Merged
luomiao pushed a commit to luomiao/kops that referenced this issue Apr 12, 2017
@prashima
Removed hardcode from protokube logic. Fixes kubernetes#15. (kubernet…
723bc7f 
…es#46)
justinsb pushed a commit that referenced this issue Apr 25, 2017
@prashima
Removed hardcode from protokube logic. Fixes #15. (#46)
074791b
robertojrojas pushed a commit to robertojrojas/kops that referenced this issue Apr 26, 2017
@prashima @robertojrojas
Removed hardcode from protokube logic. Fixes kubernetes#15. (kubernet…
60436a8 
…es#46)
cloudbow pushed a commit to cloudbow/kops that referenced this issue Jun 8, 2018
Merge pull request kubernetes#46 in SAPI/slingtv-proxy-api from featu…
c5297d1 
…re/kubernetes_leagues_nfl_ncaaf to develop

* commit 'ccc93e4651e4d7e78cc1e53a5c08d44e7625bf6e':
  Remove the startTimeEpoch check inorder to get all games which are in STATS
  Add OnFailure as restart policy for Live Jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
1 participant
@justinsb