-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.7β1 kops get ig returns SIGSEGV with get ig on darwin #3011
Comments
This is caused by omitting the |
I am guessing that we are not checking that the all we make to get cluster is returning a nil. |
justinsb
added a commit
to justinsb/kops
that referenced
this issue
Jul 24, 2017
Based on the stack trace in kubernetes#3011 Fix kubernetes#3011
justinsb
added a commit
to justinsb/kops
that referenced
this issue
Jul 24, 2017
Generally check the return value where we can't tolerate it being nil, similar to the case seen in kubernetes#3011.
justinsb
added a commit
to justinsb/kops
that referenced
this issue
Jul 24, 2017
Generally check the return value where we can't tolerate it being nil, similar to the case seen in kubernetes#3011.
aknuds1
pushed a commit
to aknuds1/kops
that referenced
this issue
Aug 25, 2017
Based on the stack trace in kubernetes#3011 Fix kubernetes#3011
aknuds1
pushed a commit
to aknuds1/kops
that referenced
this issue
Aug 25, 2017
Generally check the return value where we can't tolerate it being nil, similar to the case seen in kubernetes#3011.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using kops 1.7 beta 1 to get ig information I received a segfault with a nil pointer reference.
Darwin ITHAA1CSELLERS 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64
brew install --HEAD kops
exception:
$ kops get ig
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x1db6252]
goroutine 1 [running]:
k8s.io/kops/pkg/client/simple/vfsclientset.(*VFSClientset).InstanceGroupsFor(0xc420019d90, 0x0, 0x2b, 0x0)
/private/tmp/kops-20170720-86340-li679e/src/k8s.io/kops/pkg/client/simple/vfsclientset/clientset.go:54 +0x22
main.RunGetInstanceGroups(0xc420056478, 0xc420a21300, 0x0, 0x4, 0x1, 0xc420056440)
/private/tmp/kops-20170720-86340-li679e/src/k8s.io/kops/cmd/kops/get_instancegroups.go:93 +0x234
main.NewCmdGetInstanceGroups.func1(0xc420225d40, 0xc420a21300, 0x0, 0x4)
/private/tmp/kops-20170720-86340-li679e/src/k8s.io/kops/cmd/kops/get_instancegroups.go:65 +0x48
k8s.io/kops/vendor/github.com/spf13/cobra.(*Command).execute(0xc420225d40, 0xc420a212c0, 0x4, 0x4, 0xc420225d40, 0xc420a212c0)
/private/tmp/kops-20170720-86340-li679e/src/k8s.io/kops/vendor/github.com/spf13/cobra/command.go:603 +0x22b
k8s.io/kops/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x5a81820, 0x3884300, 0x0, 0x0)
/private/tmp/kops-20170720-86340-li679e/src/k8s.io/kops/vendor/github.com/spf13/cobra/command.go:689 +0x339
k8s.io/kops/vendor/github.com/spf13/cobra.(*Command).Execute(0x5a81820, 0x5ab1c70, 0x0)
/private/tmp/kops-20170720-86340-li679e/src/k8s.io/kops/vendor/github.com/spf13/cobra/command.go:648 +0x2b
main.Execute()
/private/tmp/kops-20170720-86340-li679e/src/k8s.io/kops/cmd/kops/root.go:98 +0x9b
main.main()
/private/tmp/kops-20170720-86340-li679e/src/k8s.io/kops/cmd/kops/main.go:25 +0x2_0
Command should return (if proper environment settings are set e.g. --state --name):
kops get ig
NAME ROLE MACHINETYPE MIN MAX SUBNETS
...
...
...
The text was updated successfully, but these errors were encountered: