Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a set of tags at the cluster level #241

Closed
justinsb opened this issue Aug 2, 2016 · 3 comments
Closed

Support a set of tags at the cluster level #241

justinsb opened this issue Aug 2, 2016 · 3 comments

Comments

@justinsb
Copy link
Member

justinsb commented Aug 2, 2016

e.g. billing tags

We should then apply these tags to the launch configuration etc so that AWS billing works nicely.
justinsb added a commit to justinsb/kops that referenced this issue Aug 2, 2016
@justinsb
Temporarily ignore changes on the ASG
dc5feca 
This is to permit users to add tags to the ASG.

The long-term fix is to allow specification of additional tags at the
cluster level; the canonical use-case is for the AWS billing tags.

Issue kubernetes#241
@justinsb justinsb mentioned this issue Aug 2, 2016
Merged
@justinsb justinsb modified the milestone: 1.3.1 Aug 3, 2016
@justinsb
Copy link
Member Author

We should support:

  • AWS tags
  • k8s labels
  • both on the cluster & instance group level.

@mrichmon
Copy link

Auto-tagging at the instance level to support AWS billing and automation such as scripts that people use to automatically shutdown AWS instances unless tagged appropriately.

justinsb added a commit to justinsb/kops that referenced this issue Sep 29, 2016
@justinsb
Add docs for labels
efe206e 
Fix kubernetes#441

Fix kubernetes#241

Issue kubernetes#311
@justinsb justinsb mentioned this issue Sep 29, 2016
Merged
@ajohnstone
Copy link
Contributor

this still seems to be an issue.

kops version
Version git-e1a9aad

W1107 16:32:14.488208   16122 autoscalinggroup.go:192] Ignoring tag changes until we have #241: %vmap[k8s.io/role/master:1 Name:master-eu-west-1c.masters.production-a-cluster.k8s-production.photobox.com KubernetesCluster:production-a-cluster.k8s-production.photobox.com AwsType:k8s Department:web Owner:[email protected] Project:k8s]

@FrederikNJS FrederikNJS mentioned this issue Dec 8, 2016
Closed
krisnova added a commit to DualSpark/kops that referenced this issue Dec 11, 2016
@krisnova
Removing workaround for kubernetes#241
195007b
chrislovecnm added a commit that referenced this issue Dec 11, 2016
@chrislovecnm
Merge pull request #1125 from DualSpark/fix-log-about-issue-241
dc63402 
Removing workaround for #241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinsb @ajohnstone @mrichmon