Skip to content

Commit

Permalink
Merge pull request #9231 from justinsb/mixed_instance_policy_no_insta…
Browse files Browse the repository at this point in the history
…nce_types_ok

Validation: MixedInstancePolicy need not override instance types
  • Loading branch information
k8s-ci-robot authored Jun 1, 2020
2 parents fddfe09 + bced4c3 commit 28a30e8
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/apis/kops/validation/instancegroup.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,6 @@ func ValidateInstanceGroup(g *kops.InstanceGroup) field.ErrorList {
func validatedMixedInstancesPolicy(path *field.Path, spec *kops.MixedInstancesPolicySpec, ig *kops.InstanceGroup) field.ErrorList {
var errs field.ErrorList

if len(spec.Instances) < 2 {
errs = append(errs, field.Invalid(path.Child("instances"), spec.Instances, "must be 2 or more instance types"))
}
// @step: check the instances are validate
for i, x := range spec.Instances {
errs = append(errs, awsValidateMachineType(path.Child("instances").Index(i).Child("instanceType"), x)...)
Expand Down

0 comments on commit 28a30e8

Please sign in to comment.