Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-interpolate feature argument to the convert command #1954

Closed
wants to merge 2 commits into from

Conversation

jvitor83
Copy link
Contributor

@jvitor83 jvitor83 commented Nov 6, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow the generated files to keep the environment variable placeholders in order to be interpolated in a later moment.

Which issue(s) this PR fixes:

Fixes #1953

Special notes for your reviewer:

This didn't pretend to put all compose keys to support the "env var placeholder" to not be interpolated, but the basic (most used ones) like "image" and "environments". Otherwise, it will be a huge effort to support this kind of feature. I guess each "non-supported" attribute can have it own issue and addressed as needed (as said in the #1953).

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 6580652 feat(config-content): added support for content in config
  • ca4f63e feat(no-interpolate): add no-interpolate feature option to the cli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jvitor83
Once this PR has been reviewed and has the lgtm label, please assign cdrage for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2024
@jvitor83 jvitor83 closed this Nov 6, 2024
@jvitor83 jvitor83 deleted the feature/no-interpolate branch November 6, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add no-interpolate to allow the generated files to keep the variable placeholder
2 participants