-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1821 update Dockerfile to alwyas use head Alpine #1824
Conversation
|
Welcome @thelamer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo this is an awesome improvement! LGTM!
/approve
/lgtm
You'll just have to sign the CLI and this will be merged 🎉
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, thelamer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes#1821 update Dockerfile to alwyas use head Alpine
What type of PR is this?
/kind bug
What this PR does / why we need it:
This updates the current Dockerfile to support aarch64 and armv7 as well, it also bumps to always use head Alpine instead of the previous hard coded 3.9. Given your instructions only use busybox for the ability to cd into the /opt directory this can likely be based down to scratch with some minor doc updates, but that is not the purpose of this PR and the space savings are negligible to potentially break external workflows.
Which issue(s) this PR fixes:
Fixes #1821