Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1821 update Dockerfile to alwyas use head Alpine #1824

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

thelamer
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This updates the current Dockerfile to support aarch64 and armv7 as well, it also bumps to always use head Alpine instead of the previous hard coded 3.9. Given your instructions only use busybox for the ability to cd into the /opt directory this can likely be based down to scratch with some minor doc updates, but that is not the purpose of this PR and the space savings are negligible to potentially break external workflows.

Which issue(s) this PR fixes:

Fixes #1821

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 12, 2024
Copy link

linux-foundation-easycla bot commented Feb 12, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: thelamer / name: Ryan Kuba (61680d1)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 12, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @thelamer!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 12, 2024
@thelamer thelamer mentioned this pull request Feb 12, 2024
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo this is an awesome improvement! LGTM!

/approve

/lgtm

You'll just have to sign the CLI and this will be merged 🎉

@cdrage
Copy link
Member

cdrage commented Feb 12, 2024

/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 12, 2024
@cdrage
Copy link
Member

cdrage commented Feb 12, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, thelamer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit d872afb into kubernetes:main Feb 12, 2024
10 checks passed
sosan pushed a commit to sosan/kompose that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bump Alpine
3 participants