-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 1778 #1799
fix issue 1778 #1799
Conversation
/hold |
I forget why this is on hold haha |
ping @sosan |
@AhmedGrati yup |
@sosan can you rebase please? |
@AhmedGrati done |
@sosan Same here, the rebase went wrong. |
* fix issue kubernetes#1778 *add tests with hardcoded values to mokup file access Signed-off-by: jose luis <[email protected]>
…secrets are created in Kubernetes from a KomposeObject, and secrets are taken from a CNAME file. Also, a newSecrets function is added to generate secrets from the provided configuration Signed-off-by: jose luis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better and thank you for adding the tests. This LGTM!
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, sosan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix issue 1778
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1778
Special notes for your reviewer:
i runned action Kompose CI, but get error from action, i checked result and expect and it's very similar
https://github.com/sosan/kompose/actions/runs/7479241247/job/20355974505