Backfill integration tests for selecting log destinations

[hoegaarden]

What this PR does / why we need it:

It adds some integration tests around the flags

• -log_dir
• -log_file
• -logtostderr
• -alsologtostderr
• -stderrthreshold

and how they play together.

Which issue(s) this PR fixes:
none

Special notes for your reviewer:

These tests are just capturing the current state. They show, I believe, some discrepancies around

• -logtostderr & -stderrthreshold
• when traces are printed to stderr

and potentially others. These tests might allow us to drive out changes and should guard against unintentionally change the current behaviour.

Related:

• Add trace message output #79 Add trace message output
• Difficult to configure logging to file #60 Difficult to configure logging to file
• Confusing arguments #54 Confusing arguments

Release note:

NONE

[k8s-ci-robot]

Welcome @hoegaarden!

It looks like this is your first PR to kubernetes/klog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/klog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[hoegaarden]

/assign dims neolit123

[neolit123]

thanks for these very detailed tests @hoegaarden
i'm curious where are these going to be called?

but instead of "e2e tests" i would qualify them as "integration tests".

[neolit123]

/priority important-longterm

[hoegaarden]

i'm curious where are these going to be called?

Well, those tests run as part of go test ./..., therefore currently on travis or locally when you run said go test.

but instead of "e2e tests" i would qualify them as "integration tests".

I don't have a strong opinion on that. It is not really about integrating different parts with each other but it is running a klog'ed executable (a small one but still) and inspecting how it behaves (at least certain aspects). But happy to rename that form e2e to integration.

All in all, thanks for your comments, I will try to address them shortly.

[hoegaarden]

@neolit123 PTAL -- Thanks!

[neolit123]

/lgtm

[dims]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hoegaarden, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment