Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go.sum #198

Merged
merged 1 commit into from
Nov 30, 2020
Merged

fix go.sum #198

merged 1 commit into from
Nov 30, 2020

Conversation

pohly
Copy link

@pohly pohly commented Nov 23, 2020

What this PR does / why we need it:

Commit 29a2d64 bumped logr in go.mod without the corresponding change
in go.sum, with the result that any go invocation (for example "go
test .") leads to a modified repo.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2020
@detiber
Copy link
Member

detiber commented Nov 23, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
Commit 29a2d64 bumped logr in go.mod without the corresponding change
in go.sum, with the result that any go invocation (for example "go
test .") leads to a modified repo.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2020
@pohly
Copy link
Author

pohly commented Nov 24, 2020

Rebased and force-pushed to re-trigger testing. apidiff should pass, now that PR #199 is merged.

@detiber
Copy link
Member

detiber commented Nov 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2020
@dims
Copy link
Member

dims commented Nov 30, 2020

/approve
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, dims, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit ea3b07f into kubernetes:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants