Skip to content

Commit

Permalink
github: bump golangci-lint image version
Browse files Browse the repository at this point in the history
It looks like golangci-lint comes with a fixed version of Go, one which is too
old for the code:

level=error msg="Running error: gofmt: analysis skipped: errors in package: [/go/src/k8s.io/klog/test/output.go:846:22: Discard not declared by package io /go/src/k8s.io/klog/test/output.go:864:40: Discard not declared by package io /go/src/k8s.io/klog/test/output.go:876:35: Discard not declared by package io]"

io.Discard was introduced in Go 1.16, using it should be fine and is reflected
in our Go version test matrix (>= 1.17).
  • Loading branch information
pohly authored and dims committed Jan 19, 2023
1 parent 8eadf2c commit 1025055
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Lint
run: |
docker run --rm -v `pwd`:/go/src/k8s.io/klog -w /go/src/k8s.io/klog \
golangci/golangci-lint:v1.23.8 golangci-lint run --disable-all -v \
golangci/golangci-lint:v1.50.1 golangci-lint run --disable-all -v \
-E govet -E misspell -E gofmt -E ineffassign -E golint
apidiff:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 1025055

Please sign in to comment.