Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ingress-nginx project for use of image promoter #882

Merged
merged 1 commit into from
May 26, 2020
Merged

Add ingress-nginx project for use of image promoter #882

merged 1 commit into from
May 26, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 19, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2020
@aledbf
Copy link
Member Author

aledbf commented May 19, 2020

/hold

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. labels May 19, 2020
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra labels May 19, 2020
@aledbf aledbf mentioned this pull request May 19, 2020
Merged
8 tasks
dims
dims reviewed May 20, 2020
View reviewed changes
groups/groups.yaml Outdated Show resolved Hide resolved
@dims
Copy link
Member

dims commented May 20, 2020

@aledbf a couple of nits, please take a look

@aledbf aledbf mentioned this pull request May 20, 2020
Merged
@aledbf
Copy link
Member Author

aledbf commented May 20, 2020

@dims please review again.
Thanks

@spiffxp
Copy link
Member

spiffxp commented May 20, 2020

Currently blocked on #852

@aledbf
Copy link
Member Author

aledbf commented May 20, 2020

@spiffxp thank you for the update

@spiffxp
Copy link
Member

spiffxp commented May 22, 2020 •
edited
Loading

/approve
I'll leave this here anyway since it LGTM, I just checked and we're still blocked unfortunately

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@spiffxp
Copy link
Member

spiffxp commented May 26, 2020

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit efeefb3 into kubernetes:master May 26, 2020
@spiffxp
Copy link
Member

spiffxp commented May 26, 2020

Updated groups and ran ./infra/gcp/ensure-staging-storage.sh ingress-nginx

@aledbf
Copy link
Member Author

aledbf commented May 26, 2020

@spiffxp thank you!

This was referenced May 28, 2020
Closed
Closed
@aledbf aledbf deleted the ingress-nginx branch June 3, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@thockin thockin Awaiting requested review from thockin

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @dims @spiffxp @k8s-ci-robot