-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add staging project provider-aws #859
add staging project provider-aws #859
Conversation
LGTM but we're blocked until we can get billing project quota raised ref: #852 |
/lgtm |
infra/gcp/ensure-staging-storage.sh
Outdated
@@ -44,6 +44,7 @@ STAGING_PROJECTS=( | |||
autoscaling | |||
build-image | |||
cip-test | |||
cloud-provider-aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please rename this to provider-aws
? it's too long otherwise
@andrewsykim please see note inside please follow the pattern of /hold |
Signed-off-by: Andrew Sy Kim <[email protected]>
829f68e
to
007bbd5
Compare
@dims updated, thanks |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updated groups and ran |
We need a GCR image for https://github.com/kubernetes/cloud-provider-aws
cc @nckturner @justinsb
Signed-off-by: Andrew Sy Kim [email protected]