Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add staging project provider-aws #859

Merged
merged 1 commit into from
May 26, 2020

Conversation

andrewsykim
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2020
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra labels May 11, 2020
@spiffxp
Copy link
Member

spiffxp commented May 11, 2020

LGTM but we're blocked until we can get billing project quota raised ref: #852

@bartsmykla
Copy link
Contributor

/lgtm
/hold as @spiffxp we have to wait for quota to be raised

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2020
@@ -44,6 +44,7 @@ STAGING_PROJECTS=(
autoscaling
build-image
cip-test
cloud-provider-aws
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please rename this to provider-aws? it's too long otherwise

@dims
Copy link
Member

dims commented May 20, 2020

@andrewsykim please see note inside please follow the pattern of provider-xxxx else the project name is too long

/hold

@andrewsykim andrewsykim force-pushed the cloud-provider-aws-gcr branch from 829f68e to 007bbd5 Compare May 20, 2020 14:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2020
@andrewsykim andrewsykim changed the title add staging project for cloud-provider-aws add staging project provider-aws May 20, 2020
@andrewsykim
Copy link
Member Author

@dims updated, thanks

@spiffxp
Copy link
Member

spiffxp commented May 26, 2020

/approve
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit eea375a into kubernetes:master May 26, 2020
@spiffxp
Copy link
Member

spiffxp commented May 26, 2020

Updated groups and ran ./infra/gcp/ensure-staging-storage.sh provider-aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants