Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added staging repository for infra-tools #805

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Added staging repository for infra-tools #805

merged 1 commit into from
Apr 30, 2020

Conversation

bartsmykla
Copy link
Contributor

Following step no. 1 at #783 I want to prepare the staging registry for our instance of octodns from k/k8s.io/dns/octodns-docker which will be used to automate dns updates.

As I didn't get the consensus yet I'm asking you guys to lgtm it
/cc @dims @spiffxp @thockin

I asked @munnerz if he would like to help me with the infra-tools if there will be need in the future so I've put our names in the OWNERS file.

Signed-off-by: Bart Smykla [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra labels Apr 27, 2020
thockin
thockin reviewed Apr 27, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this.

/lgtm
/approve
/hold

In case others want to weigh in

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bartsmykla, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@stp-ip
Copy link
Member

stp-ip commented Apr 28, 2020

sgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2020
@bartsmykla
Copy link
Contributor Author

Removed unnecessary empty line in OWNERS file

thockin
thockin reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2020
@bartsmykla
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 71f2582 into kubernetes:master Apr 30, 2020
@bartsmykla bartsmykla deleted the infra-tools-staging-registry branch April 30, 2020 08:19
@bartsmykla
Copy link
Contributor Author

@cblecker @dims @spiffxp @thockin please, can you run ensure-staging-storage.sh script?

This was referenced Apr 30, 2020
Merged
Closed
@spiffxp
Copy link
Member

spiffxp commented Apr 30, 2020

ran make -C groups -- --confirm

@spiffxp
Copy link
Member

spiffxp commented Apr 30, 2020

ran ensure-staging-storage.sh infra-tools

@spiffxp spiffxp mentioned this pull request May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@dims dims Awaiting requested review from dims

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bartsmykla @k8s-ci-robot @stp-ip @spiffxp @thockin