Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kops - Create S3 bucket for hosting CI results #6950

Closed
wants to merge 1 commit into from

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jul 6, 2024

Barring a better solution for interacting with both a GCS bucket and the Kops AWS account in one prow job (see kubernetes/kops#16637 (comment)), I'm experimenting with storing Kops' version markers and CI artifacts on S3 instead of GCS, that way the prow jobs only need to interact with one cloud provider.

I will test this with kubernetes/kops#16659 and kubernetes/test-infra#32918

/cc @upodroid @hakman

@k8s-ci-robot k8s-ci-robot requested review from hakman and upodroid July 6, 2024 01:58
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Jul 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rifelpet
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 6, 2024
@upodroid
Copy link
Member

upodroid commented Jul 6, 2024

Instead of doing this, I can fix the rbac issues

@rifelpet
Copy link
Member Author

rifelpet commented Jul 6, 2024

Ok that works for me too. kubetest2-kops today uses the k8s-staging-kops bucket you introduced here:

The new pull-kops-e2e-k8s-aws-calico-k8s-infra job that runs on the k8s-infra-kops-prow-build prow cluster reports this error:

AccessDeniedException: 403 [email protected] does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist).

If we can fix that RBAC then we should be able to migrate all presubmit jobs.

If we reuse the k8s-staging-kops bucket for version markers, we just need to update the version markers in our prow jobs to use the new bucket:

https://github.com/kubernetes/test-infra/blob/ff39426505bbbfea5b4a70e9213ffd070bdb5db4/config/jobs/kubernetes/kops/build_jobs.py#L755

Let me know when you've fixed the RBAC and I can continue with this migration work.

@rifelpet rifelpet closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants