Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Add a replication role for registry.k8s.io #5994

Merged
merged 1 commit into from
Oct 18, 2023
Merged

AWS: Add a replication role for registry.k8s.io #5994

merged 1 commit into from
Oct 18, 2023

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 18, 2023

Related to:

Define permissions needed to use S3 replication in the same account.

@ameukam
AWS: Add a replication role for registry.k8s.io
7ef0533 
Related to:
 - kubernetes/registry.k8s.io#172

Define permissions needed to use S3 replication in the same account.

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2023
@ameukam
Copy link
Member Author

ameukam commented Oct 18, 2023

cc @bryantbiggs

@k8s-ci-robot k8s-ci-robot requested a review from dims October 18, 2023 19:38
@k8s-ci-robot k8s-ci-robot added the area/infra Infrastructure management, infrastructure design, code in infra/ label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from thockin October 18, 2023 19:38
@k8s-ci-robot k8s-ci-robot added area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023
bryantbiggs
bryantbiggs approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm based off https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/blob/master/examples/s3-replication/iam.tf

@k8s-ci-robot
Copy link
Contributor

@bryantbiggs: changing LGTM is restricted to collaborators

In response to this:

/lgtm based off https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/blob/master/examples/s3-replication/iam.tf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam
Copy link
Member Author

ameukam commented Oct 18, 2023

cc @dims

@dims
Copy link
Member

dims commented Oct 18, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, bryantbiggs, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9bf9931 into kubernetes:main Oct 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 18, 2023
@bryantbiggs bryantbiggs mentioned this pull request Mar 25, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @k8s-ci-robot @dims @bryantbiggs