Adding k8s-infra-kops-scale-tests bucket with public read #5696
Conversation
|
@pkprzekwas: GitHub didn't allow me to request PR reviews from the following users: prateekgogia. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
cncf-cla: yes
infra/aws/terraform/s3/k8s-infra-e2e-boskos-scale-001/providers.tf
Outdated
Show resolved
Hide resolved
|
/approve Leave to @prateekgogia |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, pkprzekwas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| # Local .terraform directories | ||
| **/.terraform/* | ||
|
|
There was a problem hiding this comment.
@pkprzekwas suggestion: we should probably move this .gitignore file to ../infra/aws/terraform so all the sub-repos inherit this config.
There was a problem hiding this comment.
We can think about having some generic ignore at the top level of the terraform directory. But that should be a dedicated PR that would also remove other ignores.
There was a problem hiding this comment.
Yeah. let's do that in a separate PR.
|
LGTM |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Creating dedicated bucket with public read access for kops scale tests (as discussed here)
/assign @ameukam @dims
/cc @prateekgogia