Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPO v0.8.0-alpha.0 #5510

Merged
merged 1 commit into from
Jul 6, 2023
Merged

CAPO v0.8.0-alpha.0 #5510

merged 1 commit into from
Jul 6, 2023

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Jul 5, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2023
@mnaser mnaser mentioned this pull request Jul 5, 2023
Closed
tormath1
tormath1 approved these changes Jul 6, 2023
View reviewed changes
Copy link

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks !

@k8s-ci-robot
Copy link
Contributor

@tormath1: changing LGTM is restricted to collaborators

In response to this:

LGTM. Thanks !

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, tormath1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mdbooth
Copy link
Contributor Author

mdbooth commented Jul 6, 2023

@tormath1: changing LGTM is restricted to collaborators

Now you need to join the kubernetes org, too! It's a formality if you're already in kuberentes-sigs.

@dulek
Copy link
Contributor

dulek commented Jul 6, 2023

The SHA256 matches the repo and I can pull the image.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit b868744 into kubernetes:main Jul 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 6, 2023
@mdbooth mdbooth deleted the capo-v0.8.0-alpha.0 branch July 6, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tormath1 tormath1 tormath1 approved these changes

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

@tobiasgiese tobiasgiese Awaiting requested review from tobiasgiese

Assignees

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
4 participants
@mdbooth @k8s-ci-robot @dulek @tormath1