-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image promotion for etcd 3.5.8-0 #5157
Conversation
Welcome @kkkkun! |
Hi @kkkkun. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
After kubernetes/kubernetes#117332 merged. I found https://console.cloud.google.com/gcr/images/k8s-staging-etcd/global/etcd only has a image with Could someone help me? |
I think you should change |
Thanks. I would update https://github.com/kubernetes/k8s.io/blob/main/registry.k8s.io/images/k8s-staging-etcd/images.yaml#L17. But i do not found
|
@kkkkun That is correct, however, the postsubmit failed: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kubernetes-push-image-etcd/1649533793343639552 I think it might be related to removing support for arm (cc @saschagrunert @dims). |
888236b
to
32cbc52
Compare
Add kubernetes/kubernetes#117557 to track. |
We need merge this change firstly before kubernetes/kubernetes#117335 (comment). |
Signed-off-by: kkkkun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
/assign @xmudrii @justaugustus |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kkkkun, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of kubernetes/kubernetes#117341
Based on: kubernetes/kubernetes#117332
Required for: kubernetes/kubernetes#117335