Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade archeio #5078

Merged
merged 2 commits into from
Apr 4, 2023
Merged

upgrade archeio #5078

merged 2 commits into from
Apr 4, 2023

Conversation

BenTheElder
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra Infrastructure management, infrastructure design, code in infra/ labels Apr 4, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin April 4, 2023 18:22
@k8s-ci-robot k8s-ci-robot added area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2023
@BenTheElder
Copy link
Member Author

BenTheElder commented Apr 4, 2023 •
edited
Loading

kubernetes/registry.k8s.io@v0.2.0...v0.2.1

These changes are mostly in cmd/geranos (unrelated), docs, issue templates etc

There's some pretty minor refactoring, and the golang upgrade. (focus on cmd/archeio and pkg/)

@BenTheElder
Copy link
Member Author

BenTheElder commented Apr 4, 2023 •
edited
Loading

Go update: kubernetes/registry.k8s.io@bf0d11a (important-ish, Header Parsing DOS)

Bug fix: kubernetes/registry.k8s.io@2884e47 (not important, but should be safe, permitting other digest formats besides sha256)

No-runtime-code-change package rename: kubernetes/registry.k8s.io@03eeee3 (definitely safe, just moved a package to internal)

@BenTheElder BenTheElder mentioned this pull request Apr 4, 2023
Merged
@dims
Copy link
Member

dims commented Apr 4, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

Reviewed plan and applying. Changes look expected. (add explicit -v=0, update image)

@k8s-ci-robot k8s-ci-robot merged commit 824b9a8 into kubernetes:main Apr 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 4, 2023
@BenTheElder
Copy link
Member Author

This is 100% live. Logs look normal, test pulls are fine.

@BenTheElder BenTheElder deleted the archeio-patch branch April 4, 2023 19:13
@BenTheElder BenTheElder mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra Infrastructure management, infrastructure design, code in infra/ area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @dims @k8s-ci-robot