Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze the old k8s.gcr.io image registry #5035

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Mar 27, 2023

Fixes: kubernetes/release#2947
Fixes: kubernetes/enhancements#3720

Merging this PR will freeze the old registry.

/cc @kubernetes/release-engineering @dims @BenTheElder

@k8s-ci-robot
Copy link
Contributor

@upodroid: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-engineering.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: kubernetes/release#2947
Fixes: kubernetes/enhancements#3720

Merging this PR will freeze the old registry.

1st commit will delete the old registries

2nd commit will add the new AR registries we created. @ameukam What are the new rules?

/cc @kubernetes/release-engineering @dims @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Mar 27, 2023
@ameukam
Copy link
Member

ameukam commented Mar 27, 2023

2nd commit will add the new AR registries we created. @ameukam What are the new rules?

Not sure to understand the question but let's add the new AR regions in a different PR and probably after the redirect is done. the regional-equivalent buckets for those new AR repositories are still not created.

I also suggest we merge this PR on April 3th morning CET.

@upodroid
Copy link
Member Author

upodroid commented Mar 27, 2023

sounds good

/hold till the 3rd of April

Not sure to understand the question but let's add the new AR regions in a different PR and probably after the redirect is done. the regional-equivalent buckets for those new AR repositories are still not created.

Correct. I meant regions instead of rules

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2023
@upodroid upodroid force-pushed the freeze-gcr-io-registry branch from 43f8f2f to d8ec07c Compare March 27, 2023 14:16
@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. area/k8s.gcr.io Code in k8s.gcr.io/ labels Mar 27, 2023
@upodroid upodroid force-pushed the freeze-gcr-io-registry branch 2 times, most recently from c23a9b6 to 20efbb7 Compare March 27, 2023 14:24
@ameukam
Copy link
Member

ameukam commented Mar 27, 2023

Correct. I meant regions instead of rules

See:

@upodroid upodroid force-pushed the freeze-gcr-io-registry branch from 20efbb7 to a3af621 Compare March 27, 2023 14:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 27, 2023
@BenTheElder
Copy link
Member

/hold

we're in progress to fully redirecting some images including tag lists currently so actually enacting the freeze is going to put us in a lose lose if we find any issues. Will start a slack thread for higher bandwidth in a moment. This is due to the skew issue with backing stores.

@upodroid
Copy link
Member Author

@puerco Did we manage to fix the missing sigstore layers in the backing registries?

@puerco
Copy link
Member

puerco commented Apr 10, 2023

@upodroid We merged some improvements to the image promoter which should allow it to run with the AR rate limit, this should stop the problem from getting bigger.

The missing sigantures are still missing. We haven't run the remediation jobs yet as we agreed to wait until the redirect rollout is done, or at least getting it green lighted when there is enough confidence enough that the redirect is still within its error budget.

@TerryHowe
Copy link
Member

Ready on this yet?

@BenTheElder
Copy link
Member

Yes, yesterday we lifted kubernetes/registry.k8s.io#181, however the ROI is still lower than pre-redirect and many folks are away at KubeCon so it might not be the best week for this. I do still think we should do this.

@sftim
Copy link
Contributor

sftim commented Apr 24, 2023

We're now post-KubeCon.

@BenTheElder
Copy link
Member

/hold cancel
/assign @thockin @dims

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@thockin
Copy link
Member

thockin commented Apr 24, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@thockin
Copy link
Member

thockin commented Apr 24, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@upodroid upodroid force-pushed the freeze-gcr-io-registry branch from a3af621 to 1580a96 Compare April 25, 2023 13:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2023
@upodroid
Copy link
Member Author

I rebased the PR and picked up the latest set of registries. This is ready now

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, thockin, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c77f29 into kubernetes:main Apr 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freezing k8s.gcr.io implementation details Freeze k8s.gcr.io image registry
9 participants