Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jackfrancis and remove shysank as CAPZ maintainers #3816

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Add jackfrancis and remove shysank as CAPZ maintainers #3816

merged 1 commit into from
Jun 14, 2022

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Jun 7, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Jun 7, 2022
@jackfrancis
Copy link
Contributor

danke @mboersma

@jsturtevant
Copy link
Contributor

lgtm

@mboersma mboersma force-pushed the sync-capz-maintainers-4 branch from a0cd6fa to 1f331e6 Compare June 13, 2022 22:20
@mboersma
Copy link
Contributor Author

Updated to remove @shysank from the list of active reviewers. See kubernetes-sigs/cluster-api-provider-azure#2366.

@mboersma
Copy link
Contributor Author

/retitle Add jackfrancis and remove shysank as CAPZ reviewers

@k8s-ci-robot k8s-ci-robot changed the title Add jackfrancis as a CAPZ reviewer Add jackfrancis and remove shysank as CAPZ reviewers Jun 13, 2022
@mboersma
Copy link
Contributor Author

/assign @CecileRobertMichon

CecileRobertMichon
CecileRobertMichon reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma
Copy link
Contributor Author

/retitle Add jackfrancis and remove shysank as CAPZ maintainers

@k8s-ci-robot k8s-ci-robot changed the title Add jackfrancis and remove shysank as CAPZ reviewers Add jackfrancis and remove shysank as CAPZ maintainers Jun 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6962e67 into kubernetes:main Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 14, 2022
@mboersma mboersma deleted the sync-capz-maintainers-4 branch June 14, 2022 17:47
@mboersma mboersma mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@Jont828 Jont828 Awaiting requested review from Jont828

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@mboersma @jackfrancis @jsturtevant @k8s-ci-robot @CecileRobertMichon