Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/k8s.io: Change service type #2896

Merged
merged 1 commit into from
Oct 8, 2021
Merged

apps/k8s.io: Change service type #2896

merged 1 commit into from
Oct 8, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 8, 2021

Ref: #2488

The service already use a NEG.

Signed-off-by: Arnaud Meukam [email protected]

@ameukam
apps/k8s.io: Change service type
b2d2976 
Ref: kubernetes#2488

The service already use a NEG.
Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/apps Application management, code in apps/ labels Oct 8, 2021
@k8s-ci-robot k8s-ci-robot requested review from aojea and spiffxp October 8, 2021 05:09
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Oct 8, 2021
@ameukam
Copy link
Member Author

ameukam commented Oct 8, 2021

cc @dims @spiffxp @thockin

spiffxp
spiffxp approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3d532a8 into kubernetes:main Oct 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 8, 2021
@ameukam ameukam mentioned this pull request Oct 8, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@aojea aojea Awaiting requested review from aojea

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @spiffxp