-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audit: update as of 2021-09-24 #2815
audit: update as of 2021-09-24 #2815
Conversation
1429e61
to
759df45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Time updated: Fri, 24 Sep 2021 20:11:44 GMT | ||
Metageneration: 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensure_gcs_bucket_logging
still doesn't seem to be fully idempotent... this is from a run of ensure-staging-storage.sh
I did across all staging projects to ensure everything was up to date
{ | ||
"members": [ | ||
"group:[email protected]" | ||
], | ||
"role": "roles/cloudkms.cryptoKeyEncrypter" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is #2805
{ | ||
"createTime": "2019-12-17T22:16:50.466Z", | ||
"lifecycleState": "ACTIVE", | ||
"name": "k8s-staging-txtdirect", | ||
"parent": { | ||
"id": "758905017065", | ||
"type": "organization" | ||
}, | ||
"projectId": "k8s-staging-txtdirect", | ||
"projectNumber": "662592719730" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is #2727
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-ci-robot, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Audit Updates sig-k8s-infra