Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Switch jobs to ClusterIP and NEG #2731

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 15, 2021

Ref: #2488.

Convert kubernetes services for world-accessible from NodePort to
ClusterIP.

Signed-off-by: Arnaud Meukam [email protected]

Ref: kubernetes#2488.

Convert kubernetes services for world-accessible from NodePort to
ClusterIP.

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Copy link
Member Author

ameukam commented Sep 15, 2021

cc @spiffxp @thockin

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added area/apps Application management, code in apps/ area/apps/sippy sippy.k8s.io, code in apps/sippy/ approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps/slack-infra slack.k8s.io, slack-infra, code in apps/slack-infra area/apps/triageparty-release release.triage.k8s.io, triage-party, code in apps/triageparty-release area/release-eng Issues or PRs related to the Release Engineering subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra wg/reliability Categorizes an issue or PR as relevant to WG Reliability labels Sep 15, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 78e0b80 into kubernetes:main Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps/sippy sippy.k8s.io, code in apps/sippy/ area/apps/slack-infra slack.k8s.io, slack-infra, code in apps/slack-infra area/apps/triageparty-release release.triage.k8s.io, triage-party, code in apps/triageparty-release area/apps Application management, code in apps/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/reliability Categorizes an issue or PR as relevant to WG Reliability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants