-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give Amy Chen access to pushing to cluster-api staging registry #268
Conversation
Welcome @amy! |
Hi @amy. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@amy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@amy can you please get a +1/lgtm from one of the leads? |
/assign |
@timothysc or @justinsb, can you give a +1 here? This work will allow more than just you to push new release container images for cluster-api :D |
@chuckha your +1 is good enough since you are already in the group. /approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉 🎉
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ran the update for this. |
Are these staging repos now actively being used? That would be good to
know so they don't get nuked as we iterate on setup...
…On Wed, May 29, 2019 at 10:38 PM Kubernetes Prow Robot < ***@***.***> wrote:
Merged #268 <#268> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#268?email_source=notifications&email_token=ABKWAVEQBEUDEHB4LSBABL3PX5R4ZA5CNFSM4HQUIY22YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORWYEUAA#event-2377140736>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKWAVHU4HR6TDEVZIIXZLTPX5R4ZANCNFSM4HQUIY2Q>
.
|
Reference Issue: kubernetes-sigs/cluster-api-provider-aws#795
Summary: I would like to smooth out the release process for cluster-api and need access to pushing images to the staging registry.