Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra/gcp: Add bucket for kOps #2678

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 8, 2021

Ref: #2625

Add GCS bucket for kOps CI prowjobs results as replacement of
gs://kops-ci.

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. labels Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. wg/k8s-infra labels Sep 8, 2021
@ameukam
Copy link
Member Author

ameukam commented Sep 8, 2021

Need to be deployed post-merge
cc @dims @spiffxp

Ref: kubernetes#2625

Add GCS bucket for kOps CI prowjobs results as replacement of
`gs://kops-ci`.

Signed-off-by: Arnaud Meukam <[email protected]>
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2d2e6bc into kubernetes:main Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 9, 2021
@ameukam
Copy link
Member Author

ameukam commented Sep 9, 2021

Ran terraform apply:

Plan: 2 to add, 0 to change, 0 to destroy.
google_storage_bucket.kops_ci_bucket: Creating...
google_storage_bucket.kops_ci_bucket: Creation complete after 1s [id=k8s-infra-kops-ci-results]
google_storage_bucket_iam_policy.kops_ci_bucket_bindings: Creating...
google_storage_bucket_iam_policy.kops_ci_bucket_bindings: Creation complete after 1s [id=b/k8s-infra-kops-ci-results]

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

@ameukam
Copy link
Member Author

ameukam commented Sep 9, 2021

cc @justinsb

ameukam added a commit to ameukam/test-infra that referenced this pull request Sep 9, 2021
Ref: kubernetes/k8s.io#2625
Followup of : kubernetes/k8s.io#2678

Add canary jobs that publish kops version markers to
gs://k8s-infra-kops-ci-results.

Signed-off-by: Arnaud Meukam <[email protected]>
ameukam added a commit to ameukam/test-infra that referenced this pull request Sep 9, 2021
Ref: kubernetes/k8s.io#2625
Followup of : kubernetes/k8s.io#2678

Add canary jobs that publish kops version markers to
gs://k8s-infra-kops-ci-results.

Signed-off-by: Arnaud Meukam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants