Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster-api-ibmcloud staging repo #2640

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Add cluster-api-ibmcloud staging repo #2640

merged 1 commit into from
Sep 3, 2021

Conversation

mkumatag
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. labels Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added area/groups Google Groups management, code in groups/ area/k8s.gcr.io Code in k8s.gcr.io/ wg/k8s-infra do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 31, 2021
@mkumatag mkumatag mentioned this pull request Aug 31, 2021
Closed
4 tasks
@mkumatag mkumatag force-pushed the add-cluster-api-provider-ibmcloud branch from 3f545d8 to eccee67 Compare August 31, 2021 04:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 31, 2021
@mkumatag
Copy link
Member Author

/test pull-k8sio-groups-test

@mkumatag mkumatag force-pushed the add-cluster-api-provider-ibmcloud branch 2 times, most recently from 54d03cf to 7c3a647 Compare August 31, 2021 05:24
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 31, 2021
@mkumatag
Copy link
Member Author

I don't see any error in the PR jobs, neither an error why do-not-merge/invalid-owners-file tagged, @nikhita any idea what is going wrong here?

@nikhita
Copy link
Member

nikhita commented Aug 31, 2021

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 31, 2021
@mkumatag
Copy link
Member Author

/verify-owners

oops,! thanks for that @nikhita

@mkumatag
Copy link
Member Author

/assign @cblecker @dims

@mkumatag mkumatag force-pushed the add-cluster-api-provider-ibmcloud branch 3 times, most recently from 7b77316 to 5b9770e Compare August 31, 2021 13:58
@k8s-ci-robot k8s-ci-robot added the area/infra Infrastructure management, infrastructure design, code in infra/ label Aug 31, 2021
@dims
Copy link
Member

dims commented Aug 31, 2021

/approve
/lgtm

@spiffxp @ameukam do we already have automation for the gcb buckets? or should one of us run it by hand?

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@ameukam
Copy link
Member

ameukam commented Aug 31, 2021

/approve
/lgtm

@spiffxp @ameukam do we already have automation for the gcb buckets? or should one of us run it by hand?

/hold

@dims we still need to run the scripts for those by hand.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2021
@mkumatag mkumatag force-pushed the add-cluster-api-provider-ibmcloud branch from 5b9770e to 9dfa1a2 Compare September 1, 2021 11:11
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 1, 2021
@mkumatag
Copy link
Member Author

mkumatag commented Sep 3, 2021

I just resolved the merge conflicts and pushed the PR, I don't want to bother @dims as he is on vacation, wondering someone can help me merge this PR and get the resource creates @ameukam @cblecker @spiffxp

spiffxp
spiffxp approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mkumatag, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented Sep 3, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2f68e97 into kubernetes:main Sep 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 3, 2021
@mkumatag
Copy link
Member Author

mkumatag commented Sep 3, 2021

Thanks, @spiffxp I can see the google group and a GCS buckets as well :)

@mkumatag mkumatag deleted the add-cluster-api-provider-ibmcloud branch September 3, 2021 10:28
@spiffxp
Copy link
Member

spiffxp commented Sep 3, 2021 •
edited
Loading

Ran ./infra/gcp/bash/ensure-staging-storage.sh capi-ibmcloud

@saschagrunert saschagrunert mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@nikhita nikhita Awaiting requested review from nikhita

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

@spiffxp spiffxp

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
7 participants
@mkumatag @nikhita @dims @ameukam @k8s-ci-robot @spiffxp @cblecker