Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup infra/gcp/terraform mv detritus #2485

Merged
merged 1 commit into from
Aug 6, 2021
Merged

cleanup infra/gcp/terraform mv detritus #2485

merged 1 commit into from
Aug 6, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 6, 2021 •
edited
Loading

Related:

specifically

  • remove the script that made the move
  • go over the scripted substitutions since some of them were clearly
    wrong

/cc @ameukam

/cc @MushuEE
Thank you for the catches, that would have been a pain to discover after
the fact

@spiffxp
cleanup infra/gcp/terraform mv detritus
a6f0e9a 
specifically
- remove the script that made the move
- go over the scripted substitutions since some of them were clearly
  wrong
@k8s-ci-robot k8s-ci-robot requested review from ameukam and MushuEE August 6, 2021 18:47
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/audit Audit of project resources, audit followup issues, code in audit/ area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2021
@ameukam
Copy link
Member

ameukam commented Aug 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4895ff3 into kubernetes:main Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 6, 2021
@spiffxp spiffxp deleted the mv-clusters-terraform-cleanup branch August 6, 2021 19:37
@ameukam
Copy link
Member

ameukam commented Aug 8, 2021

Ref: #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam Awaiting requested review from ameukam

@MushuEE MushuEE Awaiting requested review from MushuEE

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @ameukam