prow: match prow-build-trusted nodepool to prow-build

[spiffxp]

the motivating factor here is trying to run the triage job on this
cluster, which asks for more memory than an n1-standard-8 can provide

but in general I can't think of a good reason to restrict this cluster
to less resources than the regular prow-build cluster, while having it
match the cluster would create less surprises when transferring a job
from one to the other for whatever reason

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• infra/gcp/clusters/projects/k8s-infra-prow-build-trusted/OWNERS [spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ameukam]

/lgtm
/hold
Remove hold when ready to deploy.

[ameukam]

FYI #2438.

[spiffxp]

I'd rather tackle changing instance type later, achieving parity is my goal for now

[spiffxp]

/hold cancel

[spiffxp]

Uh... why did it not change any of the nodepool settings?

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.prow_build_nodepool.google_container_node_pool.node_pool will be updated in-place
  ~ resource "google_container_node_pool" "node_pool" {
        id                  = "projects/k8s-infra-prow-build-trusted/locations/us-central1/clusters/prow-build-trusted/nodePools/trusted-pool1-20200430235251092500000001"
        name                = "trusted-pool1-20200430235251092500000001"
        # (9 unchanged attributes hidden)

      ~ autoscaling {
          ~ max_node_count = 3 -> 6
            # (1 unchanged attribute hidden)
        }



        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

[spiffxp]

OK, I figured out why, PR is here: #2480

Going to apply with that change

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
+/- create replacement and then destroy

Terraform will perform the following actions:

  # module.prow_build_nodepool.google_container_node_pool.node_pool must be replaced
+/- resource "google_container_node_pool" "node_pool" {
      ~ id                  = "projects/k8s-infra-prow-build-trusted/locations/us-central1/clusters/prow-build-trusted/nodePools/trusted-pool1-20200430235251092500000001" -> (known after apply)
      ~ instance_group_urls = [
          - "https://www.googleapis.com/compute/v1/projects/k8s-infra-prow-build-trusted/zones/us-central1-a/instanceGroupManagers/gke-prow-build-trust-trusted-pool1-20-fd38017e-grp",
          - "https://www.googleapis.com/compute/v1/projects/k8s-infra-prow-build-trusted/zones/us-central1-f/instanceGroupManagers/gke-prow-build-trust-trusted-pool1-20-caef7902-grp",
          - "https://www.googleapis.com/compute/v1/projects/k8s-infra-prow-build-trusted/zones/us-central1-b/instanceGroupManagers/gke-prow-build-trust-trusted-pool1-20-5e50b276-grp",
        ] -> (known after apply)
      + max_pods_per_node   = (known after apply)
      ~ name                = "trusted-pool1-20200430235251092500000001" -> (known after apply)
      ~ node_count          = 1 -> (known after apply)
      ~ node_locations      = [
          - "us-central1-a",
          - "us-central1-b",
          - "us-central1-f",
        ] -> (known after apply)
      + operation           = (known after apply)
      ~ version             = "1.20.8-gke.900" -> (known after apply)
        # (5 unchanged attributes hidden)



      ~ node_config {
          ~ disk_type         = "pd-standard" -> "pd-ssd" # forces replacement
          ~ guest_accelerator = [] -> (known after apply)
          ~ image_type        = "COS" -> "UBUNTU_CONTAINERD"
          ~ labels            = {} -> (known after apply)
          ~ local_ssd_count   = 0 -> (known after apply)
          ~ machine_type      = "n1-standard-8" -> "n1-highmem-8" # forces replacement
          - tags              = [] -> null
            # (6 unchanged attributes hidden)

          ~ shielded_instance_config {
              ~ enable_integrity_monitoring = true -> (known after apply)
              ~ enable_secure_boot          = false -> (known after apply)
            }

            # (1 unchanged block hidden)
        }

      ~ upgrade_settings {
          ~ max_surge       = 1 -> (known after apply)
          ~ max_unavailable = 0 -> (known after apply)
        }
        # (2 unchanged blocks hidden)
    }

[spiffxp]

Apply complete! Resources: 1 added, 0 changed, 1 destroyed.

[ameukam]

💸 💸