Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [email protected] group to handle email coming to LWKD #2455

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Add [email protected] group to handle email coming to LWKD #2455

merged 1 commit into from
Aug 6, 2021

Conversation

jberkus
Copy link
Contributor

@jberkus jberkus commented Aug 3, 2021

as well as account registrations.

@mrbobbytables @alisondy @cblecker @nikhita please approve, thanks.

Signed-off-by: Josh Berkus [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2021
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2021
@coderanger
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2021
spiffxp
spiffxp approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take @mrbobbytables saying "I'm okay with lwkd too" here https://kubernetes.slack.com/archives/CCK68P2Q2/p1628020926017500 as enough of an LGTM for the sig

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 551d305 into kubernetes:main Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@nikhita nikhita Awaiting requested review from nikhita

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@spiffxp spiffxp

@coderanger coderanger

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@jberkus @coderanger @k8s-ci-robot @spiffxp